[ https://issues.apache.org/jira/browse/SOLR-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981674#comment-15981674 ]
Varun Thacker commented on SOLR-9527: ------------------------------------- I reviewed the latest patch ( 6th April ) and here are a few things I believe we should fix: - Should we rename {{DocCollection#getReplicaCount}} to {{DocCollection#getNodeCount}} ? - RestoreCmd has an unused import. We should generally remove all unused imports to make "ant precommit" happy {code} String createNodeArg = message.getStr(CREATE_NODE_SET, null); if (createNodeArg == CREATE_NODE_SET_EMPTY) { throw new SolrException( SolrException.ErrorCode.BAD_REQUEST, "Cannot restore with a CREATE_NODE_SET of CREATE_NODE_SET_EMPTY." ); } {code} - Can we move this check from RestoreCmd to the CollectionsHandler#RESTORE_OP? - In line 206 of RestoreCmd , shouldn't {{int repFactor = backupCollectionState.getReplicaCount();}} be {{int repFactor = message.getInt(REPLICATION_FACTOR, backupCollectionState.getReplicaCount());}} - We should also allow users to pass {{createNodeSet.shuffle}} > Solr RESTORE api doesn't distribute the replicas uniformly > ----------------------------------------------------------- > > Key: SOLR-9527 > URL: https://issues.apache.org/jira/browse/SOLR-9527 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Affects Versions: 6.1 > Reporter: Hrishikesh Gadre > Assignee: Varun Thacker > Attachments: SOLR-9527.patch, SOLR-9527.patch, SOLR-9527.patch, > SOLR-9527.patch, Solr 9527.pdf > > > Please refer to this email thread for details, > http://lucene.markmail.org/message/ycun4x5nx7lwj5sk?q=solr+list:org%2Eapache%2Elucene%2Esolr-user+order:date-backward&page=1 -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org