[
https://issues.apache.org/jira/browse/SOLR-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982689#comment-15982689
]
Jason Gerlowski edited comment on SOLR-10535 at 4/25/17 10:44 AM:
------------------------------------------------------------------
Ran the script Christine uploaded, with some tweaks to have it catch {{.txt}}
and {{.html}} files, as well as {{.xml}}. I still mainly caught xml files, but
at least the other ones were checked for.
I also poked around the {{@AwaitsFix}} files as suggested above, to make sure
none of the deleted files are used in those tests.
{{ant test}} passes on a local run.
was (Author: gerlowskija):
Ran the script Christine uploaded, with some tweaks to have it catch {{.txt}}
and {{.html}} files, as well as {{.xml}}. I still mainly caught xml files, but
at least the other ones were checked for.
I also poked around the {{@AwaitsFix}} files as suggested above, to make sure
none of the deleted files are used in those tests.
All tests pass on a local run.
> identify and remove unused test files
> -------------------------------------
>
> Key: SOLR-10535
> URL: https://issues.apache.org/jira/browse/SOLR-10535
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-10535.patch
>
>
> It appears that a number of test files are unused and hence could/should be
> removed.
> Step 1:
> * identify potentially unused files e.g.
> {code}
> for ff in `find ./solr/core/src/test-files -name "*.xml"`
> do
> file=`basename $ff`
> git grep -l $file >/dev/null
> rcode=$?
> if [[ $rcode -ne 0 ]]
> then
> echo $ff
> fi
> done
> {code}
> Step 2:
> * remove the files concerned
> * run {{ant test}} to check if tests still pass
> * create patch or pull request
> Step 3:
> * optionally share any scripts or commands used in steps 1 and 2
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
