[
https://issues.apache.org/jira/browse/LUCENE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039171#comment-13039171
]
Michael McCandless commented on LUCENE-3143:
--------------------------------------------
Looks good!
Maybe sharpen the comment to something like: this method creates a compound
file for all files returned by info.files(). While, generally, this may
include separate norms and deletion files, this SegmentInfo must not reference
such files when this method is called, because they are not allowed within a
compound file. Something like that...?
> SegmentMerger should assert .del and .s* files are not passed to
> createCompoundFile
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-3143
> URL: https://issues.apache.org/jira/browse/LUCENE-3143
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3143.patch
>
>
> Spinoff from LUCENE-3126. SegmentMerger.createCompoundFile does not document
> that it should not receive files that are not included in the .cfs, such as
> .del and .s* (separate norms). Today, that method is called from code which
> ensures that, but we should:
> # Add some documentation to clarify that.
> # Add some asserts so that if a test (or other code, running w/ -ea) does
> that, we catch it.
> Will post a patch soon
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
