[ 
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986780#comment-15986780
 ] 

Dawid Weiss commented on LUCENE-7796:
-------------------------------------

I ran several dozen runs of the full core (Lucene) test suite. I detected a 
problem related to another issue (OfflineSorter, already fixed by Mike), but 
nothing else popped up. 

I added deprecated versions of methods that were previously in IOUtils, along 
with a verbose javadoc comment and example stating how the new method can be 
used. 

I'll attach the final patch in a second and commit tomorrow if there are no 
other comments.

> Make reThrow idiom declare Error return type so callers may use it in a way 
> that compiler knows subsequent code is unreachable
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7796
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7796
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 6.x, master (7.0)
>
>         Attachments: LUCENE-7796.patch
>
>
> A spinoff from LUCENE-7792: reThrow can be declared to return an unchecked 
> exception so that callers can choose to use {{throw reThrow(...)}} as an 
> idiom to let the compiler know any subsequent code will be unreachable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to