[
https://issues.apache.org/jira/browse/SOLR-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996760#comment-15996760
]
Andrey Kudryavtsev edited comment on SOLR-9867 at 5/4/17 2:01 PM:
------------------------------------------------------------------
But what if we, [you
know|https://issues.apache.org/jira/secure/attachment/12866408/SOLR-9867.patch]....
{code}
- private void setupJvmMetrics() {
+ private void setupJvmMetrics(CoreContainer cores) {
SolrMetricManager metricManager = cores.getMetricManager();
final Set<String> hiddenSysProps = cores.getConfig().getHiddenSysProps();
try {
@@ -247,7 +247,7 @@ public class SolrDispatchFilter extends BaseSolrFilter {
*/
protected CoreContainer createCoreContainer(Path solrHome, Properties
extraProperties) {
NodeConfig nodeConfig = loadNodeConfig(solrHome, extraProperties);
- cores = new CoreContainer(nodeConfig, extraProperties, true);
+ CoreContainer cores = new CoreContainer(nodeConfig, extraProperties, true);
cores.load();
return cores;
}
{code}
was (Author: werder):
But what if we, you know....
{code}
- private void setupJvmMetrics() {
+ private void setupJvmMetrics(CoreContainer cores) {
SolrMetricManager metricManager = cores.getMetricManager();
final Set<String> hiddenSysProps = cores.getConfig().getHiddenSysProps();
try {
@@ -247,7 +247,7 @@ public class SolrDispatchFilter extends BaseSolrFilter {
*/
protected CoreContainer createCoreContainer(Path solrHome, Properties
extraProperties) {
NodeConfig nodeConfig = loadNodeConfig(solrHome, extraProperties);
- cores = new CoreContainer(nodeConfig, extraProperties, true);
+ CoreContainer cores = new CoreContainer(nodeConfig, extraProperties, true);
cores.load();
return cores;
}
{code}
> The Solr examples can not always be started after being stopped due to race
> with loading core.
> ----------------------------------------------------------------------------------------------
>
> Key: SOLR-9867
> URL: https://issues.apache.org/jira/browse/SOLR-9867
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Assignee: Mikhail Khludnev
> Priority: Critical
> Fix For: 6.6, master (7.0)
>
> Attachments: Lucene-Solr-master-MacOSX #3986 Console [Jenkins].htm,
> SDF init and doFilter in parallel.png,
> SOLR-9867-createCoreContainer-fix.patch, SOLR-9867-ignore-whitespace.patch,
> SOLR-9867.patch, SOLR-9867.patch, SOLR-9867.patch, SOLR-9867.patch,
> SOLR-9867.patch, SOLR-9867.patch, SOLR-9867-test.patch, stdout_90
>
>
> I'm having trouble when I start up the schemaless example after shutting down.
> I first tracked this down to the fact that the run example tool is getting an
> error when it tries to create the SolrCore (again, it already exists) and so
> it deletes the cores instance dir which leads to tlog and index lock errors
> in Solr.
> The reason it seems to be trying to create the core when it already exists is
> that the run example tool uses a core status call to check existence and
> because the core is loading, we don't consider it as existing. I added a
> check to look for core.properties.
> That seemed to let me start up, but my first requests failed because the core
> was still loading. It appears CoreContainer#getCore is supposed to be
> blocking so you don't have this problem, but there must be an issue, because
> it is not blocking.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
