[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-7871:
------------------------------
Attachment: SOLR-7871.patch
New version of patch
* Tests back compat
* Removes {{bin/solr.in.sh}} and {{solr.in.cmd}}, adds {{bin/solr.conf.sample}}
* Integrated into {{bin/solr}}, instead of searching for and sourcing
{{solr.in.sh}}, we do a call to {{SolrCliConfig.java}} which does it all in
pure Java, returning a long string which are {{eval}}'ed in bin/solr.
Todo:
* Integrate into {{bin/solr.cmd}}, test on Windows
* More testing of quoting and corner cases, this may be a bit fragile
* Currently still values in {{solr.conf}} will override existing env in shell,
need to do it other way around
* Decide name of file (solr.conf, solr.properties, solr.in.conf)?
* The {{solr.conf}} file is currently parsed by same code as {{solr.in.sh}},
could perhaps look into using some standard properties / config parser from
some lib?
* Documentation
> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
> Key: SOLR-7871
> URL: https://issues.apache.org/jira/browse/SOLR-7871
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 5.2.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Labels: bin/solr
> Fix For: master (7.0)
>
> Attachments: SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable
> batch files, but all they do is to set environment variables for the start
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g.
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by
> {{SolrCLI.java}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
