[
https://issues.apache.org/jira/browse/SOLR-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001872#comment-16001872
]
Scott Blum commented on SOLR-10619:
-----------------------------------
[~caomanhdat] patch LGTM. I would update the main class comment on
DistributedQueue to read:
"A distributed queue. Optimized for single-consumer, multiple-producer: if
there are multiple consumers on the same ZK queue, the results should be
correct but inefficient."
And then where you call "knownChildren.clear();" you could add a comment
"Efficient only for single-consumer"
> When DQ.knowChildren is not empty, DQ should not refetch node children in
> case of single consumer
> -------------------------------------------------------------------------------------------------
>
> Key: SOLR-10619
> URL: https://issues.apache.org/jira/browse/SOLR-10619
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Cao Manh Dat
> Assignee: Cao Manh Dat
> Attachments: SOLR-10619.patch, SOLR-10619.patch, SOLR-10619.patch
>
>
> Right now, for every time childWatcher is kicked off. We refetch all children
> of DQ's node. It is a wasted in case of single consumer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
