[ 
https://issues.apache.org/jira/browse/SOLR-10617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005815#comment-16005815
 ] 

Dennis Gove edited comment on SOLR-10617 at 5/11/17 2:43 AM:
-------------------------------------------------------------

bq. Does the Interface at the bottom need to be in its own source file per our 
guidelines?
The interface is only used internally. I've moved it inside the class body so 
it's a clear part of the JDBCStream class.

bq. How does the java.sql.Array bit work? I haven't encountered sql ARRAY type 
before, and I'm not seeing anything on it in the docs/tests/etc.
Some databases are able to return Array objects. For example, Postgres's jsonb 
function jsonb_build_array 
(https://www.postgresql.org/docs/9.5/static/functions-json.html) can result in 
an array existing in the resultset. The idea here is that an object array would 
be placed in the Tuple under the field name.


was (Author: dpgove):
bq. Does the Interface at the bottom need to be in its own source file per our 
guidelines?
The interface is only used internally. I've moved it inside the class body so 
it's a clear part of the JDBCStream class.

bq. How does the java.sql.Array bit work? I haven't encountered sql ARRAY type 
before, and I'm not seeing anything on it in the docs/tests/etc.
Some databases are able to return Array objects. For example, Postgres's jsonb 
function jsonb_build_array 
(https://www.postgresql.org/docs/9.5/static/functions-json.html) can result in 
an array existing in the resultset.

> JDBCStream: support more data types
> -----------------------------------
>
>                 Key: SOLR-10617
>                 URL: https://issues.apache.org/jira/browse/SOLR-10617
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>            Reporter: James Dyer
>            Assignee: James Dyer
>            Priority: Minor
>         Attachments: SOLR-10617.patch, SOLR-10617.patch, SOLR-10617.patch
>
>
> It would be nice if JDBCStream could support Decimal types as well as 
> Timestamp-related types, and CLOBs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to