[
https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006516#comment-16006516
]
Keith Laban commented on SOLR-10654:
------------------------------------
Seems like there a few things here:
1.
- a: Pull reporter framework. An interesting idea, but is it over engineering
for an initial effort? I'm not aware any other mainstream metrics frameworks
that pull metrics in a very specific format. Any home rolled thing can consume
the default format we expose.
- b: Additionally, we can expose these metrics under {{/metrics/prometheus}}
like suggested above, to avoid having to change the api if we later decide
there is a need for more generic framework.
2. Response writers. It might be interesting to expose response writers
dynamically with a plugin-style interface. Or add a Function to the response
object that can dictate the writer to be used (optionally). Either way, I think
this is separate enough from metrics, and useful in other places, that it
should be pursued in a separate issue.
3. Dropwizard Exports - yes, there is not feature parity with default solr
metrics, but is it required for an initial patch? To me it seems like a lot of
work that isn't required on day one. But I agree it should be added at some
point.
I propose that we tackle #2 and #1.b for the initial patch. And circle back to
#3 and #1.a if we find it necessary.
> Expose Metrics in Prometheus format
> -----------------------------------
>
> Key: SOLR-10654
> URL: https://issues.apache.org/jira/browse/SOLR-10654
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Reporter: Keith Laban
>
> Expose metrics via a `wt=prometheus` response type.
> Example scape_config in prometheus.yml:
> {code}
> scrape_configs:
> - job_name: 'solr'
> metrics_path: '/solr/admin/metrics'
> params:
> wt: ["prometheus"]
> static_configs:
> - targets: ['localhost:8983']
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
