[
https://issues.apache.org/jira/browse/LUCENE-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-3147:
-------------------------------
Attachment: LUCENE-3147.patch
Renamed all IOUtils methods to closeSafely. With Simon's fix, the names don't
collide anymore. Thanks Simon !
Fixed to two TODO + one other place to use IOUtils.closeSafely collection
version.
Added CHANGES entry.
There is one nocommit, but I think it's already handled? The code already
rethrows TIE:
{code}
} catch (ThreadInterruptedException t) {
throw t;
} catch (Throwable t) {
// It's OK if we fail to write this file since it's
// used only as one of the retry fallbacks.
// nocommit if this is thread interrupted we should rethrow
}
{code}
I think this is ready to commit to trunk, and then will start backporting to 3x.
> MockDirectoryWrapper should track open file handles of IndexOutput too
> ----------------------------------------------------------------------
>
> Key: LUCENE-3147
> URL: https://issues.apache.org/jira/browse/LUCENE-3147
> Project: Lucene - Java
> Issue Type: Test
> Components: general/test
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch,
> LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch,
> LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch
>
>
> MockDirectoryWrapper currently tracks open file handles of IndexInput only.
> Therefore IO files that are not closed do not fail our tests, which can then
> lead to test directories fail to delete on Windows. We should make sure all
> open files are tracked and if they are left open, fail the test. I'll attach
> a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
