[
https://issues.apache.org/jira/browse/SOLR-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016045#comment-16016045
]
David Smiley commented on SOLR-10585:
-------------------------------------
The change I suggest is to HighlightComponent.process. Here's the _existing
code_:
{code}
String[] defaultHighlightFields; //TODO: get from builder by default?
if (rb.getQparser() != null) {
defaultHighlightFields = rb.getQparser().getDefaultHighlightFields();
} else {
defaultHighlightFields = params.getParams(CommonParams.DF);
}
{code}
Make it:
{code}
//TODO: get from builder by default?
String[] defaultHighlightFields = rb.getQparser() != null ?
rb.getQparser().getDefaultHighlightFields() : null;
{code}
This simplification is possible because the {{df}} lookup is now in
SolrHighligher with your change.
> Remove defaultSearchField completely in 7.0
> -------------------------------------------
>
> Key: SOLR-10585
> URL: https://issues.apache.org/jira/browse/SOLR-10585
> Project: Solr
> Issue Type: Sub-task
> Components: Schema and Analysis
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Fix For: master (7.0)
>
> Attachments: SOLR-10585.patch, SOLR-10585.patch
>
>
> Sub task of SOLR-7041.
> This will remove code related to defaultSearchField in schema and will throw
> a hard exception if a schema using this config is attempted loaded.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
