[
https://issues.apache.org/jira/browse/LUCENE-7815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016161#comment-16016161
]
David Smiley commented on LUCENE-7815:
--------------------------------------
I plan to commit this as soon as Tuesday next week in the absence of further
feedback. It does include the change to UnifiedSolrHighlighter to refer to the
correct package names of where the break iterators were moved to.
Suggested CHANGES.txt in API Changes:
* Removed the PostingsHighlighter; use the UnifiedHighlighter instead, which
was derived from the PH. WholeBreakIterator and CustomSeparatorBreakIterator
were moved to UH's package.
> Remove PostingsHighlighter in 7.0
> ---------------------------------
>
> Key: LUCENE-7815
> URL: https://issues.apache.org/jira/browse/LUCENE-7815
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/highlighter
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: master (7.0)
>
> Attachments: LUCENE_7815_Remove_PostingsHighlighter.patch
>
>
> The UnifiedHighlighter is derived from the PostingsHighlighter, which should
> be quite obvious to anyone who cares to look at them. There is no feature in
> the PH that is not also present in the UH. The PH is marked as
> {{lucene.experimental}} so we may remove it in 7.0. The upgrade path is
> pretty easy given the API similarity. By removing the PH, the goal is to
> ease maintenance. Some issues lately have been applicable to both of these
> highlighters which is annoying to apply twice. In one case I forgot to. And
> of course there is user confusion by having both.
> What I propose to do in this issue is move {{CustomSeparatorBreakIterator}}
> and {{WholeBreakIterator}} out of the {{postingshighlight}} package into the
> {{uhighlight}} package (or perhaps add a {{common}} or {{util}} should future
> highlighters need them?). Then of course remove {{postingshighlight}}
> package.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
