[
https://issues.apache.org/jira/browse/SOLR-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-10671:
---------------------------------------
Attachment: SOLR-10671.patch
[~anshumg] and I talked about this ticket yesterday and sketched out draft
changes. This alternative patch adds an abstract _doInit_ method to the
_SolrMetricReporter_ base class.
Not yet included in this patch is the addition of try-catch blocks around the
_validate()_ and _doInit()_ calls, and to potentially differentiate behavior
for _enabled=true_ vs. _enabled=false_ reporters.
Related open questions:
* How would the {{<bool name="enabled">...</bool>}} property typically be used?
* Might used of a {{enable="..."}} attribute be an alternative to the property?
e.g.
{code}
<reporter enable="..." name="..." class="...">
...
</reporter>
{code}
As far as I know, an _enable="false"_ attribute would be equivalent to the
_<reporter>_ element not being present at all whereas an _enabled="false"_
property can be explictly considered in (potentially multiple) parts of the
code.
> tweak SolrMetricReporter implementations' init/validate/start logic
> -------------------------------------------------------------------
>
> Key: SOLR-10671
> URL: https://issues.apache.org/jira/browse/SOLR-10671
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-10671.patch, SOLR-10671.patch
>
>
> This ticket proposes to
> * leave SolrJmxReporter unchanged
> * turn Solr(Cluster|Shard)Reporter.validate into
> Solr(Cluster|Shard)Reporter.init
> * factor out Solr(Ganglia|Graphite|Slf4j)Reporter.init from
> Solr(Ganglia|Graphite|Slf4j)Reporter.validate
> Motivation and Intention:
> * Consistency w.r.t. what logic SolrMetricReport implementations should place
> in which method.
> * Even reporters that are not enabled to pass the validate() check.
> * The validate() method to have no (init-ialising) side effects.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
