Shalin Shekhar Mangar created SOLR-10738:
--------------------------------------------
Summary: TriggerAction is initialised even if the trigger is never
scheduled
Key: SOLR-10738
URL: https://issues.apache.org/jira/browse/SOLR-10738
Project: Solr
Issue Type: Sub-task
Security Level: Public (Default Security Level. Issues are Public)
Components: SolrCloud
Reporter: Shalin Shekhar Mangar
Assignee: Shalin Shekhar Mangar
Fix For: master (7.0)
The zk watcher responsible for creating triggers creates them blindly without
checking if the trigger is actually modified. This is be design as
ScheduledTriggers.add is a no-op if the trigger being added is unchanged.
However, since the trigger's actions are initialised in the trigger's
constructor, they are inited needlessly by the zk watcher thread even though we
may never schedule those trigger instances (because they are unchanged). So I
propose to change the TriggerAction lifecycle such that the TriggerAction.init
is only called when the trigger is actually ready to be scheduled.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
