[
https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023119#comment-16023119
]
Jim Ferenczi edited comment on LUCENE-7844 at 5/24/17 3:49 PM:
---------------------------------------------------------------
+1 for the cleanup/code style of the code.
Regarding the API change, it seems weird because now the simple
{noformat}highlightField(String field, Query query, int docId, int
maxPassages){noformat} can also overrides the max passages count. For
consistency you could maybe remove the maxPassages entirely and rely solely on
{noformat}maxPassageCount(String field){noformat} ?
was (Author: jimczi):
+1 for the cleanup/code style of the code.
Regarding the API change, it seems weird because now the simple
{noformat}highlightField(String field, Query query, int docId, int
maxPassages){noformat} can also overrides the max passages count. For
consistency you could maybe remove the maxPassages entirely and rely solely on
{noformat}maxPassageCount{noformat} ?
> UnifiedHighlighter: simplify "maxPassages" input API
> ----------------------------------------------------
>
> Key: LUCENE-7844
> URL: https://issues.apache.org/jira/browse/LUCENE-7844
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: David Smiley
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: LUCENE_7844__UH_maxPassages_simplification.patch
>
>
> The "maxPassages" input to the UnifiedHighlighter can be provided as an array
> to some of the public methods on UnifiedHighlighter. When it's provided as
> an array, the index in the array is for the field in a parallel array. I
> think this is awkward and furthermore it's inconsistent with the way this
> highlighter customizes things on a by field basis. Instead, the parameter
> can be a simple int default (not an array), and then there can be a protected
> method like {{getMaxPassageCount(String field}} that returns an Integer
> which, when non-null, replaces the default value for this field.
> Aside from API simplicity and consistency, this will also remove some
> annoying parallel array sorting going on.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
