[ 
https://issues.apache.org/jira/browse/SOLR-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kensho Hirasawa updated SOLR-10528:
-----------------------------------
    Attachment: SOLR-10528.patch

I attached a new patch.
I removed almost all limitations from the last patch.
The only limitation is that this implementation cannot handle TrieDateField 
when both start and end are not specified.

I think tests are not sufficient still, and so I am going to add tests later. 
(there are many corner cases…)
Also, I have a few concerns and I want some comments or advices on them.
(Of course any comments on other points are welcome.)

First, I wrote almost all functions in the one class, FacetRangeProcessorByDV, 
but this may not be good design.

Secondly, the range facet by DV supports open end range (start == null || end 
== null) but it is difficult to test open end range facets in 
TestJsonFacets.testStats because the original range facet cannot support open 
end range inherently. Though I wrote the tests by limiting executions only when 
method = dv, I wonder if there are any better ways.

> Use docvalue for range faceting in JSON facet API
> -------------------------------------------------
>
>                 Key: SOLR-10528
>                 URL: https://issues.apache.org/jira/browse/SOLR-10528
>             Project: Solr
>          Issue Type: Improvement
>          Components: Facet Module
>    Affects Versions: 6.5
>            Reporter: Kensho Hirasawa
>            Priority: Minor
>         Attachments: SOLR-10528.patch, SOLR-10528.patch
>
>
> Range faceting in JSON facet API has only one implementation. In the 
> implementation, all buckets are allocated and then range queries are executed 
> for all the buckets. Therefore, memory usage and computational cost of range 
> facet can be very high if range is wide and gap is narrow. 
> I think range faceting in JSON facet should have the implementation which 
> uses DocValues instead of inverted indices. By scanning DocValues, we can 
> execute range facets much more efficiently especially when the number of 
> buckets is large.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to