[
https://issues.apache.org/jira/browse/SOLR-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025168#comment-16025168
]
Steve Rowe edited comment on SOLR-10379 at 5/25/17 6:33 PM:
------------------------------------------------------------
bq. When I apply your patch, it adds line breaks I assume at every 120
character point of a line, even in the middle of sentences. I guess that's what
I'm supposed to be looking at?
Yes, sorry I wasn't clearer.
bq. What is the point of this, or even, the big deal about asking your IDE to
do soft wraps instead?
[~dsmiley] and [~janhoy] mentioned on SOLR-10290 that wrapping long lines would
be good:
[https://issues.apache.org/jira/browse/SOLR-10290?focusedCommentId=16014709&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16014709]
and
[https://issues.apache.org/jira/browse/SOLR-10290?focusedCommentId=16015443&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16015443].
Not all editors support soft-wrapping. There is project consensus to wrap code
at 120-chars; why make an exception for these doc files?
bq. But, isn't it inconsistent to only do it on the one page you've edited?
Yes, but it would be time-consuming to do in all pages, so I thought maybe a
fix-as-we-go strategy was more prudent?
bq. Did you add the break ({{\}}) in the middle of the curl examples (such
as L#239) or did your IDE do that?
I did that.
was (Author: steve_rowe):
bq. When I apply your patch, it adds line breaks I assume at every 120
character point of a line, even in the middle of sentences. I guess that's what
I'm supposed to be looking at?
Yes, sorry I wasn't clearer.
bq. What is the point of this, or even, the big deal about asking your IDE to
do soft wraps instead?
[~dsmiley] and [~janhoy] mentioned on SOLR-10290 that wrapping long lines would
be good:
[https://issues.apache.org/jira/browse/SOLR-10290?focusedCommentId=16014709&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16014709]
and
[https://issues.apache.org/jira/browse/SOLR-10290?focusedCommentId=16015443&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16015443].
Not all editors support soft-wrapping. There is project consensus to wrap code
at 120-chars; why make an exception for these doc files?
bq. But, isn't it inconsistent to only do it on the one page you've edited?
Yes, but it would be time-consuming to do in all pages, so I thought maybe a
fix-as-we-go strategy was more prudent?
bq. Did you add the break ({{\}}) in the middle of the curl examples (such
as L#239) or did your IDE do that?
I did that.
> Add ManagedSynonymGraphFilterFactory, deprecate ManagedSynonymFilterFactory
> ---------------------------------------------------------------------------
>
> Key: SOLR-10379
> URL: https://issues.apache.org/jira/browse/SOLR-10379
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Steve Rowe
> Attachments: SOLR-10379.patch
>
>
> SynonymFilterFactory was deprecated in LUCENE-6664
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
