[
https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025178#comment-16025178
]
Timothy M. Rodriguez commented on LUCENE-7844:
----------------------------------------------
This syntax looks really good!
{code}
unifiedHighlighter.highlight(query, topDocs,
unifiedHighlighter.fieldOptionsWhole("title"),
unifiedHighlighter.fieldOptions("body", 3)
);
{code}
with maybe {code}unifiedHighlighter.fieldOptionsWhole();{code} being a
specialization of {code}unifiedHiglighter.fieldOptions("title", 3,
BreakOption.WHOLE);{code} or something to that effect
Fair point on the performance difference being negligible. In terms of now,
I'd be in favor of leaving the current parallel array approach and working
towards a fieldOption approach. I can offer to help on that end!
> UnifiedHighlighter: simplify "maxPassages" input API
> ----------------------------------------------------
>
> Key: LUCENE-7844
> URL: https://issues.apache.org/jira/browse/LUCENE-7844
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: David Smiley
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: LUCENE_7844__UH_maxPassages_simplification.patch
>
>
> The "maxPassages" input to the UnifiedHighlighter can be provided as an array
> to some of the public methods on UnifiedHighlighter. When it's provided as
> an array, the index in the array is for the field in a parallel array. I
> think this is awkward and furthermore it's inconsistent with the way this
> highlighter customizes things on a by field basis. Instead, the parameter
> can be a simple int default (not an array), and then there can be a protected
> method like {{getMaxPassageCount(String field}} that returns an Integer
> which, when non-null, replaces the default value for this field.
> Aside from API simplicity and consistency, this will also remove some
> annoying parallel array sorting going on.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
