Done.

Cheers,

Ignacio Vera

From: Michael McCandless [mailto:[email protected]]
Sent: Friday, May 26, 2017 11:02 AM
To: Lucene/Solr dev <[email protected]>; Ignacio Vera Sequeiros 
<[email protected]>
Subject: Re: Request to change visibility of classes in geo3d

I think that makes sense; can you open a Jira issue?  Thanks.

Mike McCandless

http://blog.mikemccandless.com

On Fri, May 26, 2017 at 4:46 AM, Ignacio Vera Sequeiros 
<[email protected]<mailto:[email protected]>> wrote:

Hi,



I  am creating my own spatial context by wrapping the objects in lucene geo3d 
library and implement my own query which mixes the recursive and the serialized 
strategy to add precision to searches.



I had the following issue specially with polygons:  The factory for creating 
polygons is slow and when serializing shapes, I already know if I am dealing 
with convex or concave polygons (in my case they are always concave). So when 
de-serializing a polygon I do not want to go through the factory to decide the 
type of polygon to create.



Wouldn't make sense to add the possibility to create a type of polygon 
directly? you cannot create the polygons directly as they are protected in the 
package. My suggestion request would be either to add methods in the polygon 
factory to create a type of polygons with no checking (e.g. 
makeConcavePolygon(…)) or change the visibility of the classes so that they can 
be instantiated directly.



I hope it makes sense.



Cheers,



Ignacio


Reply via email to