[
https://issues.apache.org/jira/browse/SOLR-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026599#comment-16026599
]
Jason Gerlowski edited comment on SOLR-10755 at 5/26/17 6:00 PM:
-----------------------------------------------------------------
bq. personally i think these methods provide a nice syntactic sugar in tests,
and give us wiggle room to add more testing of randomized client options in the
future
You're right of course, they could provide value at some point. It's a downer
that they suffer the same downside that prompted the initial SolrClient ctor
change though- the number of SolrClient parameters that can be provided/omitted
causes us to end up with tons of these near-duplicate methods. But if that
doesn't bother anyone, it's fine with me. Just wanted to mention it as I
created most of those methods initially and feel partially responsible for the
mess I made :-p (Relatedly, I wish I'd known about SolrTestCaseJ4 being
"external" back then, but you learn something new every day)
was (Author: gerlowskija):
> personally i think these methods provide a nice syntactic sugar in tests, and
> give us wiggle room to add more testing of randomized client options in the
> future
You're right of course, they could provide value at some point. It's a downer
that they suffer the same downside that prompted the initial SolrClient ctor
change though- the number of SolrClient parameters that can be provided/omitted
causes us to end up with tons of these near-duplicate methods. But if that
doesn't bother anyone, it's fine with me. Just wanted to mention it as I
created most of those methods initially and feel partially responsible for the
mess I made :-p (Relatedly, I wish I'd known about SolrTestCaseJ4 being
"external" back then, but you learn something new every day)
> delete/refactor (most) solrj deprecations on master
> ---------------------------------------------------
>
> Key: SOLR-10755
> URL: https://issues.apache.org/jira/browse/SOLR-10755
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Hoss Man
> Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-10755.patch, SOLR-10755.patch, SOLR-10755.patch
>
>
> using this issue to track some work i've done to cleanup deprecations in
> solrj for master (7.0)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
