[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029535#comment-16029535
]
Ignacio Vera commented on LUCENE-7853:
--------------------------------------
[~daddywri]: You are totally right, the order of the points (counter-clockwise
or clockwise) does not matter as it always generates the convex polygon. I will
try to re-phrase it an add a new patch.
Composite polygons are not appreciably slower but my strategy is to serialize
the objects to read them at query time for the boundaries of a spatial search
(inspired from SerializedDVStrategy). Having to serialize the composite polygon
and the polygon inside it and then read it during a query can have a
performance penalty when dealing with hundreds or even thousand of them.
Another more philosofical doubt I have is that composite polygons can be
confused with multipolygons. One thing I have learnt the hard way is that
multipolygons cannot be composed of polygons that intersect to each other. I
guess this is not the case for Geo3d composite polygons.
> Request to change visibility of classes in geo3d
> ------------------------------------------------
>
> Key: LUCENE-7853
> URL: https://issues.apache.org/jira/browse/LUCENE-7853
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Attachments: LUCENE-7853.patch
>
>
> I am creating my own spatial context by wrapping the objects in lucene geo3d
> library and implement my own query which mixes the recursive and the
> serialized strategy to add precision to searches.
>
> I had the following issue specially with polygons: The factory for creating
> polygons is slow and when serializing shapes, I already know if I am dealing
> with convex or concave polygons (in my case they are always concave). So when
> de-serializing a polygon I do not want to go through the factory to decide
> the type of polygon to create.
>
> Wouldn't make sense to add the possibility to create a type of polygon
> directly? you cannot create the polygons directly as they are protected in
> the package. My suggestion request would be either to add methods in the
> polygon factory to create a type of polygons with no checking (e.g.
> makeConcavePolygon(…)) or change the visibility of the classes so that they
> can be instantiated directly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
