[ 
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029672#comment-16029672
 ] 

Hoss Man commented on SOLR-8668:
--------------------------------

bq. Good catch that! I've gone and renamed from effectiveUseCompoundFileSetting 
to useCompoundFile ...

this comment still exists when the variable is used to build the IWC...

{code}
     // do this after buildMergePolicy since the backcompat logic 
     // there may modify the effective useCompoundFile
-    iwc.setUseCompoundFile(getUseCompoundFile());
+    iwc.setUseCompoundFile(useCompoundFile);
{code}

...and that's now missleading/confusing.


> Remove support for <mergePolicy> (in favour of <mergePolicyFactory>)
> --------------------------------------------------------------------
>
>                 Key: SOLR-8668
>                 URL: https://issues.apache.org/jira/browse/SOLR-8668
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Assignee: Christine Poerschke
>            Priority: Blocker
>             Fix For: master (7.0)
>
>         Attachments: SOLR-8668-part1.patch, SOLR-8668-part1.patch
>
>
> Following SOLR-8621, we should remove support for {{<mergePolicy>}} (and 
> related {{<mergeFactor>}} and {{<maxMergeDocs>}}) in trunk/6x.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to