[
https://issues.apache.org/jira/browse/SOLR-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-10757:
----------------------------
Attachment: SOLR-10757.patch
this took longer then i thought (because of how many tests were still using the
deprecated methods, and how many places had "defered" argument checks in
getParams that i moved to the constructor because there are no longer "setter"
methods ... but i think it's good to go.
We should now be able to change a lot of state variables (that are only set in
constructors) to be "final" -- but i'm going to leave that for another issue
.... this patch is huge enough.
> cleanup/refactor/fix deprecated methods/constructors in CollectionAdminRequest
> ------------------------------------------------------------------------------
>
> Key: SOLR-10757
> URL: https://issues.apache.org/jira/browse/SOLR-10757
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Hoss Man
> Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-10757.patch
>
>
> spinning off of SOLR-10755...
> * CollectionAdminRequest
> ** has roughly double the number of deprecations of all other solrj classes
> combined
> ** many of the deprecated methods/constructors are still used in a lot of
> places in tests
> ** in many cases the non-deprecated "constructor" versions aren't validating
> the same way the deprecated setters do
> ** in at least one case i see obvious bugs in the non-deprecated methods (see
> ForceLeader constructors)
> ** once many of these deprecated setters are removed, a lot of member
> variables should become final
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
