[ 
https://issues.apache.org/jira/browse/SOLR-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031508#comment-16031508
 ] 

Hoss Man commented on SOLR-10757:
---------------------------------

created SOLR-10788 to track making more variables final

> cleanup/refactor/fix deprecated methods/constructors in CollectionAdminRequest
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-10757
>                 URL: https://issues.apache.org/jira/browse/SOLR-10757
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Blocker
>             Fix For: master (7.0)
>
>         Attachments: SOLR-10757.patch
>
>
> spinning off of SOLR-10755...
> * CollectionAdminRequest
> ** has roughly double the number of deprecations of all other solrj classes 
> combined
> ** many of the deprecated methods/constructors are still used in a lot of 
> places in tests
> ** in many cases the non-deprecated "constructor" versions aren't validating 
> the same way the deprecated setters do
> ** in at least one case i see obvious bugs in the non-deprecated methods (see 
> ForceLeader constructors)
> ** once many of these deprecated setters are removed, a lot of member 
> variables should become final



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to