[ 
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man reopened LUCENE-7853:
------------------------------

precommit failures from documentation-lint...

{noformat}
     [echo] checking for broken html...
    [jtidy] Checking for broken html (such as invalid tags)...
   [delete] Deleting directory /home/hossman/lucene/dev/lucene/build/jtidy_tmp
     [echo] Checking for broken links...
     [exec] 
     [exec] Crawl/parse...
     [exec] 
     [exec] Verify...
     [exec] 
     [exec] 
file:///build/docs/spatial3d/org/apache/lucene/spatial3d/geom/GeoPolygonFactory.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConcavePolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConcavePolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConvexPolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConvexPolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConcavePolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConvexPolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConcavePolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConvexPolygon.html
     [exec] 
     [exec] 
file:///build/docs/spatial3d/org/apache/lucene/spatial3d/geom/class-use/GeoPoint.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConcavePolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConcavePolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConvexPolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConvexPolygon.html
     [exec] 
     [exec] 
file:///build/docs/spatial3d/org/apache/lucene/spatial3d/geom/class-use/GeoPolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConcavePolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConvexPolygon.html
     [exec] 
     [exec] 
file:///build/docs/spatial3d/org/apache/lucene/spatial3d/geom/class-use/PlanetModel.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConcavePolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConcavePolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConvexPolygon.html
     [exec]   BROKEN LINK: 
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoConvexPolygon.html
     [exec] 
     [exec] Broken javadocs links were found!
{noformat}

> Request to change visibility of classes in geo3d
> ------------------------------------------------
>
>                 Key: LUCENE-7853
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7853
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>             Fix For: master (7.0), 6.7
>
>         Attachments: LUCENE-7853.patch
>
>
> I  am creating my own spatial context by wrapping the objects in lucene geo3d 
> library and implement my own query which mixes the recursive and the 
> serialized strategy to add precision to searches. 
>  
> I had the following issue specially with polygons:  The factory for creating 
> polygons is slow and when serializing shapes, I already know if I am dealing 
> with convex or concave polygons (in my case they are always concave). So when 
> de-serializing a polygon I do not want to go through the factory to decide 
> the type of polygon to create.
>  
> Wouldn't make sense to add the possibility to create a type of polygon 
> directly? you cannot create the polygons directly as they are protected in 
> the package. My suggestion request would be either to add methods in the 
> polygon factory to create a type of polygons with no checking (e.g. 
> makeConcavePolygon(…)) or change the visibility of the classes so that they 
> can be instantiated directly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to