David Smiley created LUCENE-7859:
------------------------------------

             Summary: PackedQuadCell.getTokenBytesNoLeaf bug when null BytesRef
                 Key: LUCENE-7859
                 URL: https://issues.apache.org/jira/browse/LUCENE-7859
             Project: Lucene - Core
          Issue Type: Bug
          Components: modules/spatial-extras
            Reporter: David Smiley
            Assignee: David Smiley
             Fix For: master (7.0)


PackedQuadCell.getTokenBytesNoLeaf and PackedQuadCell.getTokenBytesWithLeaf 
have a couple issues that were exposed in LUCENE-7845. One is that the WithLeaf 
version actually modifies the state ({{long term}}) which it shouldn't. Another 
is that if the BytesRef is null, it can compute a different result than if it's 
not null, which is definitely wrong.

It _appears_ that these problems are only revealing themselves in practice with 
the LUCENE-7845 optimization since there has been no PackedQuad test  failure 
before, and RandomSpatialOpFuzzyPrefixTreeTest really hammers the prefix tree.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to