[
https://issues.apache.org/jira/browse/LUCENE-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041376#comment-13041376
]
Robert Muir commented on LUCENE-3161:
-------------------------------------
There are currently 18 warnings in lucene if you use java 6, all of which are
in generated code:
* jflex generates fallthrough warnings
* javacc generates dep-ann and redundant cast warnings.
Additionally on java 5-only, you will get a dep-ann warning for Version.java,
which is actually a JDK bug.
I'll commit a workaround for this issue, as its the only one in our code.
In the future, the javacc dep-ann warnings can be reduced by upgrading to the
latest javacc, which generates java-5 compatible code.
I say reduced because on java 5 it hits the same bug as above... and it still
has redundant casts.
I don't think at this time we should be upgrading any of our code generators
though, so I think a workaround for our Version.java is the best solution.
And, I don't think we should in general hide any warnings, even to users for
the reasons i mentioned above.
> consider warnings from the source compilation
> ---------------------------------------------
>
> Key: LUCENE-3161
> URL: https://issues.apache.org/jira/browse/LUCENE-3161
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
> Labels: maybe32blocker
> Fix For: 3.3, 4.0
>
>
> as Doron mentioned in his review: At compiling there are various warning
> printed, I think it would be more assuring for downloaders if the build runs
> without warning. These warnings are not a stopper.
> we could conditionalize these warnings so that they don't "display" when
> compiling from actual releases, but I have to wonder if we should hide
> these... being open source I think we should display all our warts, maybe
> some contributor sees these warnings and decides they want to submit a patch
> to fix some of them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
