[ 
https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036016#comment-16036016
 ] 

Jason Gerlowski edited comment on SOLR-10713 at 6/3/17 5:15 PM:
----------------------------------------------------------------

bq. For example, "**/foo" matches file or directory "foo" anywhere, the same as 
pattern "foo".

(from the man page you referenced)

Huh, you learn something new everyday.  Well, I've updated the patch to address 
your comments.

I did some light testing by dropping files/sub-dir trees matching the various 
ignored patterns around my checkout, and didn't find any surprises 
git-tracking-wise.  So this should be looking good, pending your approval.  
Thanks for the feedback, and for reviewing.


was (Author: gerlowskija):
> For example, "**/foo" matches file or directory "foo" anywhere, the same as 
> pattern "foo".

Huh, you learn something new everyday.  Well, I've updated the patch to address 
your comments.

I did some light testing by dropping files/sub-dir trees matching the various 
ignored patterns around my checkout, and didn't find any surprises 
git-tracking-wise.  So this should be looking good, pending your approval.  
Thanks for the feedback, and for reviewing.

> git should ignore common output files (*.pid, *.out)
> ----------------------------------------------------
>
>                 Key: SOLR-10713
>                 URL: https://issues.apache.org/jira/browse/SOLR-10713
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Build
>            Reporter: Jason Gerlowski
>            Assignee: Mike Drob
>            Priority: Trivial
>         Attachments: SOLR-10713.patch, SOLR-10713.patch, SOLR-10713.patch, 
> SOLR-10713.patch, SOLR-10713.patch
>
>
> During the course of experimenting/testing Solr, it's common to accumulate a 
> number of output files in the source checkout.  Many of these are already 
> ignored via the {{.gitignore}}.  (For example, {{*.jar}} and {{*.log}} files 
> are untracked currently)
> Some common output files aren't explicitly ignored by git though.  I know 
> this is true of {{*.pid}} and {{*.out}} files (such as those produced by 
> running a standalone ZK).
> It'd be nice if we could update the {{.gitignore}} to explicitly ignore these 
> filetypes by default.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to