[ 
https://issues.apache.org/jira/browse/LUCENE-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039208#comment-16039208
 ] 

Uwe Schindler edited comment on LUCENE-7764 at 6/6/17 4:34 PM:
---------------------------------------------------------------

I think the original patch by Daniel declares findbugs like the other tools in 
common-build. I had not yet looked at the whole setup, but the fragments look 
correct. We may at some point in the future move the ANT build tools to a 
separate IVY file, but the "tools" one is for stuff the tools require to 
compile.

In addition, the build tools don't need to have License checks, so we don't 
want the JAR files anywhere in the build tree. According to ASF licensing 
information, we don't require build tools to be ASF licensed. We had several 
discussions about this already (svnkit had a crazy, non-ASF compatible 
license), but we were allowed to use it.


was (Author: thetaphi):
I think the original patch by Daniel declares findbugs like the other tools in 
common-build. I had not yet looked at the whole setup, but the fragments look 
correct. We may at some point in the future move the ANT build tools to a 
separate IVY file, but the "tools" one is for stuff the tools require to 
compile.

> Add FindBugs analysis to precommit
> ----------------------------------
>
>                 Key: LUCENE-7764
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7764
>             Project: Lucene - Core
>          Issue Type: Sub-task
>          Components: general/build
>            Reporter: Daniel Jelinski
>            Priority: Minor
>         Attachments: LUCENE-7764-ivy.patch, LUCENE-7764.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to