[
https://issues.apache.org/jira/browse/SOLR-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039674#comment-16039674
]
Varun Thacker commented on SOLR-10671:
--------------------------------------
Hi Christine,
I was trying to write my own custom reporter to prepare for my talk next week
and noticed that this would break back-compat. So it's good that we only are
only making this change in master. We should perhaps add a note to the
"Upgrading from Solr 6.x" section of the CHANGES.txt ?
> tweak SolrMetricReporter implementations' init/validate/start logic
> -------------------------------------------------------------------
>
> Key: SOLR-10671
> URL: https://issues.apache.org/jira/browse/SOLR-10671
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: SOLR-10671.patch, SOLR-10671.patch
>
>
> This ticket proposes to
> * add abstract doInit method to the SolrMetricReporter base class
> * turn Solr(Cluster|Shard)Reporter.validate into
> Solr(Cluster|Shard)Reporter.doInit
> * factor out Solr(Ganglia|Graphite|Slf4j)Reporter.doInit from
> Solr(Ganglia|Graphite|Slf4j)Reporter.validate
> Motivation and Intention:
> * Consistency w.r.t. what logic SolrMetricReport implementations should place
> in which method.
> * Even reporters that are not enabled to pass the validate() check.
> * The validate() method to have no (init-ialising) side effects.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
