Github user diegoceccarelli commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/202#discussion_r120700095
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DocTransformers.java ---
@@ -88,4 +89,11 @@ public boolean needsSolrIndexSearcher() {
return false;
}
+ @Override
+ public void finish() {
+ for( DocTransformer a : children ) {
+ a.finish();
--- End diff --
yes? I think that if a transformer throws an exception solr request should
fail (you can still try and catch the exception inside the transformer if you
want to obtain 'silent' behaviour) what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
