[ https://issues.apache.org/jira/browse/LUCENE-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044056#comment-16044056 ]
Adrien Grand commented on LUCENE-7500: -------------------------------------- I looked at the "remove" patch, it seems to make things simpler which I like. Regarding WeigthedSpanTermExtractor, why does it fail now? I'm afraid exposing field infos that are inconsistent with terms could lead to weird bugs? > Nuke Fields.java in lieu of LeafReader.getTerms(fieldName) > ---------------------------------------------------------- > > Key: LUCENE-7500 > URL: https://issues.apache.org/jira/browse/LUCENE-7500 > Project: Lucene - Core > Issue Type: Improvement > Reporter: David Smiley > Assignee: David Smiley > Fix For: master (7.0) > > Attachments: LUCENE_7500_avoid_leafReader_fields.patch, > LUCENE_7500_avoid_leafReader_fields.patch, > LUCENE_7500_Remove_LeafReader_fields.patch, > LUCENE_7500_Remove_LeafReader_fields.patch > > > {{Fields}} seems like a pointless intermediary between the {{LeafReader}} and > {{Terms}}. Why not have {{LeafReader.getTerms(fieldName)}} instead? One loses > the ability to get the count and iterate over indexed fields, but it's not > clear what real use-cases are for that and such rare needs could figure that > out with FieldInfos. > [~mikemccand] pointed out that we'd probably need to re-introduce a > {{TermVectors}} class since TV's are row-oriented not column-oriented. IMO > they should be column-oriented but that'd be a separate issue. > _(p.s. I'm lacking time to do this w/i the next couple months so if someone > else wants to tackle it then great)_ -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org