[ 
https://issues.apache.org/jira/browse/LUCENE-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Khludnev updated LUCENE-7871:
-------------------------------------
    Attachment: LUCENE-7871.patch

bq.  Can you move ToParentIterator to the join package and make it pkg-private? 

Thanks it went really well. [^LUCENE-7871.patch] I also moved some its' guts 
inside. 
Now {{BlockJoinSelector}}'s methods accept {{DocIdSetIterator children}}, 
keeping all {{BitSet children}}-accepting methods deprecated.

The question is, what we allow {{ToParentBlockJoinSortField}} to accept as 
children? Is it {{Query}}?  or we have some other abstract per-segment DISI 
<<factory>>? 

> polish BlockJoinSelector 
> -------------------------
>
>                 Key: LUCENE-7871
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7871
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Mikhail Khludnev
>         Attachments: LUCENE-7871.patch, LUCENE-7871.patch, LUCENE-7871.patch
>
>
> * fix false positive match for SortedSetDV
> * make {{children}} iterator instead of bitset.
> see [the 
> comment|https://issues.apache.org/jira/browse/LUCENE-7407?focusedCommentId=16042640&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042640]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to