[ 
https://issues.apache.org/jira/browse/LUCENE-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044193#comment-16044193
 ] 

Adrien Grand commented on LUCENE-7871:
--------------------------------------

Since the patch is for 7.0 only, it is fine to break backward compatibility, so 
let's just remove the methods that take a bitset instead of deprecating them? 
{{hasValue}} and {{seen}} seem to store the same information, don't they? 
Finally I'm still not a fan of the {{ToParentIterator}} and {{Accumulator}} 
abstractions. I liked it better before, even if that meant a bit of duplication.

> polish BlockJoinSelector 
> -------------------------
>
>                 Key: LUCENE-7871
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7871
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Mikhail Khludnev
>         Attachments: LUCENE-7871.patch, LUCENE-7871.patch, LUCENE-7871.patch
>
>
> * fix false positive match for SortedSetDV
> * make {{children}} iterator instead of bitset.
> see [the 
> comment|https://issues.apache.org/jira/browse/LUCENE-7407?focusedCommentId=16042640&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042640]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to