[ 
https://issues.apache.org/jira/browse/SOLR-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044611#comment-16044611
 ] 

Amrit Sarkar commented on SOLR-10858:
-------------------------------------

{quote}
What about back-compat to params in solrconfig?
{quote}

Hmm, we cannot remove the solrconfig parameter definition support for URPs in 
one go, I understand. So ideally whatever working before should work (URP 
solrconfig param(s)) and if parameters are passed in the request too, they will 
override the solrconfig ones. Am I going the right way?

{quote}
Note that you could use some SolrTestCaseJ4 conveniences like params("param", 
"value") instead of explicit ModifiableSolrParams. And you could use 
req(params) instead of creating a LocalSolrQueryRequest manually. Most Solr 
tests use these and other conveniences that makes test less verbose.
{quote}

I will make the necessary changes in the tests based on above suggestions, may 
have followed the some other test class. Thank you for those pointers.

> Make UUIDUpdateProcessorFactory as Runtime URP; take params(s) in Request not 
> in Solrconfig
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-10858
>                 URL: https://issues.apache.org/jira/browse/SOLR-10858
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: update
>            Reporter: Amrit Sarkar
>            Priority: Minor
>         Attachments: SOLR-10858.patch
>
>
> As discussed with [~noble.paul], we are trying to get rid of processor 
> definitions in SolrConfig for all URPs and take parameters in the request 
> itself.
> UUIDUpdateProcessorFactory will be able to execute by sample curl like below:
> {code}
>  curl -X POST -H Content-Type: application/json  
> http://localhost:8983/solr/test/update/json/docs?processor=UUID&UUID.fieldName=id&commit=true
>  --data-binary {"title": "titleA"}
> {code}
> {code}
>  curl -X POST -H Content-Type: application/json  
> http://localhost:8983/solr/test/update/json/docs?processor=UUID&commit=true 
> --data-binary {"id":"1","title": "titleA"}
> {code}
> {code}
>  curl -X POST -H Content-Type: application/json  
> http://localhost:8983/solr/test/update/json/docs?processor=UUID&UUID.fieldName=id&commit=true
>  --data-binary {"id":"1","title": "titleA"}
> {code}
> No configuration required for UUIDUpdateProcessorFactory in solrconfig.xml.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to