[ 
https://issues.apache.org/jira/browse/SOLR-10857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erick Erickson updated SOLR-10857:
----------------------------------
    Attachment: SOLR-10857.patch

Final patch, committing momentarily. Will commit to 6.6 branch for re-spin if 
we do that.

This affected all core unloading, not just stand-alone.

If you look at the patch you'll notice a kind of scary bit where I took out the 
if test when I moved the removeCoreDescriptor, see below. This does just what 
the old code did since the core descriptor was removed anyway even when 
deleteInstanceDir==false in 6.0+ at least.

{code}

    if (deleteInstanceDir) { // we aren't going to reload this if we delete the 
instance dir.
      solrCores.removeCoreDescriptor(cd);
    }
{code}

This was another consequence of having copies of the CoreDescriptor hanging 
around in several places.

I thought about removing the CoreDescriptor from SolrCore in SOLR-10007 and 
making the internal lists of CoreDescriptors in SolrCores and the transient 
plugin be the one true source of CoreDescriptors, but decided against it at the 
time due to how intrusive that patch was already, leaving that discussion for 
another day/JIRA.

> Solr loads UNLOADed core on request
> -----------------------------------
>
>                 Key: SOLR-10857
>                 URL: https://issues.apache.org/jira/browse/SOLR-10857
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 6.6
>            Reporter: Mikhail Khludnev
>            Assignee: Erick Erickson
>         Attachments: SOLR-10857.patch, SOLR-10857.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to