[
https://issues.apache.org/jira/browse/SOLR-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047816#comment-16047816
]
Jason Gerlowski commented on SOLR-10433:
----------------------------------------
*Minor Review Comments*
- I've been trying (without much success) to garner interest in removing many
of the setters on our {{SolrClient}} implementations. Doing so would simplify
the code (fewer null-checks, validation on change, etc.), and more importantly
make the clients safer/less-trappy to use in a multi-threaded context. For a
slightly more detailed discussion, see SOLR-8975 . Your attached patch adds
two SolrClient setters: {{setPreferV2API}} and {{setUseBinaryV2}}. If the
argument above appeals to you, please consider moving those setter methods onto
the Builder for each SolrClient. (And if the argument _really_ appeals to you,
please consider adding some feedback on the patches I've uploaded on SOLR-8975
and its children. But that's a bit much to ask :-p )
- I haven't looked much at the V2 API code, so this might just be a quirk that
I'm unfamiliar with....but it strikes me as a bit odd that the V1 and V2 APIs
have different means of specifying the read-write format (RequestWriter and
ResponseParser objects for v1 APIs *vs* setUseBinaryV2 for V2 APIs). Is there
a reason that RW/RP objects/setters cannot be re-used for clients using the V2
APIs?
> automatically map collection admin calls from V1 to V2
> ------------------------------------------------------
>
> Key: SOLR-10433
> URL: https://issues.apache.org/jira/browse/SOLR-10433
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ, v2 API
> Reporter: Noble Paul
> Attachments: SOLR-10433.patch, SOLR-10433.patch, SOLR-10433.patch,
> SOLR-10433.patch
>
>
> There are some bugs in v2 api that I would like to solve in other tickets :
> - DELETE method doest not support body ( we can't pass async id )
> - V2HttpCall should {{override getAuthCtx()}} to support
> {{RuleBasedAuthorizationPlugin}}
> - with create collection, when user send this request
> {code}
> {
> "properties" : {"solr.tests.maxBufferedDocs" : 100}
> }
> {code}
> the v2 api can not resolve the value for
> "properties.solr.tests.maxBufferedDocs"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
