[ https://issues.apache.org/jira/browse/SOLR-10864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049376#comment-16049376 ]
Hoss Man commented on SOLR-10864: --------------------------------- thanks steve. I should have pointed out before: you can see an aproximation of what this will look like in the branch i've been working on for the parent issue: jira/SOLR-10807 In particular this commit gives the flavor of teh bulk of the change... https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c76a79b Unless their are any objections, i'll assume this choice is ok, and continue moving forwrad with this approach in branch jira/SOLR-10807 (once some other related bugs are fixed on maser) and resolve this issue. > Add static (test only) boolean to PointField indicating 'precisionStep' > should be ignored > ----------------------------------------------------------------------------------------- > > Key: SOLR-10864 > URL: https://issues.apache.org/jira/browse/SOLR-10864 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Hoss Man > Assignee: Hoss Man > Fix For: master (7.0) > > > (I'm spinning this idea out of parent jira SOLR-10807 so that it gets it's > own jira# w/ it's own summary for increased visibility/comments) > In the interest of making it easier & more straight forward to get good > randomized test coverage of Points fields, I'd like to add the following to > the {{PointField}} class... > {code} > /** > * <p> > * The Test framework can set this global variable to instruct PointField > that > * (on init) it should be tollerant of the <code>precisionStep</code> > argument used by TrieFields. > * This allows for simple randomization of TrieFields and PointFields w/o > extensive duplication > * of <code><fieldType/></code> declarations. > * </p> > * > * <p>NOTE: When {@link TrieField} is removed, this boolean must also be > removed</p> > * > * @lucene.internal > * @lucene.experimental > */ > public static boolean TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS = false; > /** > * NOTE: This method can be removed completely when > * {@link #TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS} is removed > */ > @Override > protected void init(IndexSchema schema, Map<String, String> args) { > super.init(schema, args); > if (TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS) { > args.remove("precisionStep"); > } > } > {code} > Then in SolrTestCaseJ4, set > {{PointField.TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS}} on a class by class > basis when randomizing Trie/Points (and unset \@AfterClass). > (details to follow in comment) -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org