[
https://issues.apache.org/jira/browse/LUCENE-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054831#comment-16054831
]
Adrien Grand commented on LUCENE-7880:
--------------------------------------
I think the source of the disagreement is that to me there is almost no good
reason to build large boolean queries. So users who really need to do this can
increase the limit. They would indeed lose the safety of that limit but it
still sounds like a better trade-off to me than removing the max clause count
entirely or making it configurable per-query.
As far as multi-tenancy is concerned, it should still be extremely rare that
large boolean queries are needed on a per-cluster basis. So I'd make it a
per-cluster option and raise the limit if any tenant needs to build large
boolean queries.
I understand my assumptions do not seem to match the reality some other
committers are seeing based on the comments on SOLR-4586. Also I don't want to
prevent Solr from setting a limit equal to MAX_VALUE or making it configurable
per-core given my position. So I won't object if you want to follow either of
those paths but I still think we should keep things as they are in Lucene since
it is our best option from a Lucene perspective.
> Make boolean query clause limit configurable per-query
> ------------------------------------------------------
>
> Key: LUCENE-7880
> URL: https://issues.apache.org/jira/browse/LUCENE-7880
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Yonik Seeley
>
> As we know, the magic BooleanQuery.maxClauseCount has bitten many people over
> time.
> It's also a static, which really hurts multi-tenancy (i.e. we can't have
> different settings for different users, clients, or use-cases).
> If we want to keep this static as a default, then at least we should allow it
> to be overridden on a per-query basis when we know it is the desired behavior
> and not a bug.
> Perhaps the simplest way to achieve this would be a setter on
> BooleanQuery.Builder that configures the limit for that instance only?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
