[
https://issues.apache.org/jira/browse/SOLR-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059682#comment-16059682
]
Hoss Man commented on SOLR-10503:
---------------------------------
bq. I made them static inner classes, but as a result had to add exceptional
classloader logic to load CurrencyFieldType inner classes (currently only
FileExchangeRateProvider).
Oh ... uck ... i'm sorry, i hadn't even thought about that -- I was just trying
to avoid "polluting" the schema package with what felt like implementation
details, I didn't even think about the fact that those classes can be
configured by name... Please ignore that suggestion and go back to the simpler
code you had before unless you think this is better for some reason.
bq. I've made this change. I think the user experience would be better with
defaults for the majority of folks who I'm guessing won't care about sub-field
details. But I'm ok with not providing them.
My take is that I'd rather we provide those "defaults" in our _sample_
configsets where they are more obvious to users who want to tweak them, and we
can trivially change them overtime w/o breaking backcompat for users who
upgrade w/their existing configs -- having "defaults in code" are much harder
for us to change.
Other notes...
* why do we need {{MethodHandles.lookup()}} in {{CurrencyFieldType.init}} and
{{checkSchemaField}} -- wouldn't {{this.getClass()}} work just as well?
* {{CurrencyField.inform(IndexSchema)}} should be calling {{super.inform()}} as
it's last step (and as a result doesn't need to explicitly assign
{{this.schema}}
> CurrencyField should be changed from TrieLongField to LongPointField for
> underlying raw-polyfield
> -------------------------------------------------------------------------------------------------
>
> Key: SOLR-10503
> URL: https://issues.apache.org/jira/browse/SOLR-10503
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Attachments: SOLR-10503.patch, SOLR-10503.patch, SOLR-10503.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
