[
https://issues.apache.org/jira/browse/LUCENE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062343#comment-16062343
]
David Smiley commented on LUCENE-7737:
--------------------------------------
bq. I guess it's a form of two-phase iteration that you wrote before we had
the core TwoPhaseIterator API?
CompositeSpatialStrategy was developed immediately after TwoPhaseIterator and
shipped in the same 5.2 release. Any way, if you can think of ways to improve
it, I'm all ears. I'm dubious that turning ShapePredicateValueSource into a
TwoPhaseIterator is clearer than what it was before -- a boolean DocValues. In
a way, a TwoPhaseIterator is sort of a boolean DocValues, but for
ShapePredicateValueSource it doesn't need/want an approximation.
When you commit, remember to remove the \@Seed in TestSolr4Spatial
Any way +1 to this patch.
> Remove spatial-extras dependency on queries
> -------------------------------------------
>
> Key: LUCENE-7737
> URL: https://issues.apache.org/jira/browse/LUCENE-7737
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Alan Woodward
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: LUCENE-7737.patch, LUCENE-7737.patch, LUCENE-7737.patch,
> LUCENE-7737.patch
>
>
> The spatial-extras module uses ValueSources for a number of different
> purposes, requiring a dependency on the queries module. I'd like to try
> using core-only interfaces here instead, allowing us to remove the dependency
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
