[ 
https://issues.apache.org/jira/browse/SOLR-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067522#comment-16067522
 ] 

Steve Rowe commented on SOLR-6807:
----------------------------------

{{CloudSolrClientTest.stateVersionParamTest()}} is now failing 100% of the time 
for me for any seed starting with commit {{82a44beb}} on this issue (according 
to {{git bisect}}).

For example, from Policeman Jenkins 
[https://jenkins.thetaphi.de/job/Lucene-Solr-master-Windows/6687/]:

{noformat}
Checking out Revision c98e2a528f13a3a05f9d4899bff54c2f519e5fb5 
(refs/remotes/origin/master)
[...]
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=CloudSolrClientTest 
-Dtests.method=stateVersionParamTest -Dtests.seed=CCC1381BB50AABC0 
-Dtests.slow=true -Dtests.locale=ff-CM -Dtests.timezone=Europe/Lisbon 
-Dtests.asserts=true -Dtests.file.encoding=US-ASCII
   [junit4] FAILURE 0.06s J0 | CloudSolrClientTest.stateVersionParamTest <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: Expected an extra 
information from server with the list of invalid collection states
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([CCC1381BB50AABC0:69F835631E100149]:0)
   [junit4]    >        at 
org.apache.solr.client.solrj.impl.CloudSolrClientTest.stateVersionParamTest(CloudSolrClientTest.java:610)
   [junit4]    >        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   [junit4]    >        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   [junit4]    >        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [junit4]    >        at 
java.base/java.lang.reflect.Method.invoke(Method.java:564)
{noformat}

> Make handleSelect=false by default and deprecate StandardRequestHandler
> -----------------------------------------------------------------------
>
>                 Key: SOLR-6807
>                 URL: https://issues.apache.org/jira/browse/SOLR-6807
>             Project: Solr
>          Issue Type: Task
>    Affects Versions: 4.10.2
>            Reporter: Alexandre Rafalovitch
>            Assignee: David Smiley
>            Priority: Minor
>              Labels: solrconfig.xml
>             Fix For: master (7.0)
>
>         Attachments: SOLR_6807_handleSelect_false.patch, 
> SOLR_6807_handleSelect_false.patch, SOLR_6807_handleSelect_false.patch, 
> SOLR_6807_test_files.patch
>
>
> In the solrconfig.xml, we have a long explanation on the legacy 
> *<requestDispatcher handleSelect="false" >* section. Since we are cleaning up 
> legacy stuff for version 5, is it safe now to flip handleSelect's default to 
> be *false* and therefore remove both the attribute and the whole section 
> explaining it?
> Then, a section in Reference Guide or even a blog post can explain what to do 
> for the old clients that still need it. But it does not seem to be needed 
> anymore for the new users. And possibly cause confusing now that we have 
> implicit, explicit and overlay handlers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to