+1 to make this warning clear and fix the default to use the accurate cache.
Mike McCandless http://blog.mikemccandless.com On Tue, Jun 27, 2017 at 4:22 AM, Rob Audenaerde <rob.audenae...@gmail.com> wrote: > Hi all, > > We bumped into a hash collision in the LruTaxonomyWriterCache, which > caused a wrong facet to be indexed for a document. (It took some time to > figure out what was going wrong..) > > The javadoc of this constructor is not explicitly telling it is unsafe > (you need to check the enum itself to see this) > > Maybe to prevent others from running into this problem, the single > argument constructor can be switched to LRU_STRING? Or some extra javadoc > to warn the developer? > > WDYT? > > -Rob > > > > >
