[
https://issues.apache.org/jira/browse/SOLR-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-6807:
-------------------------------
Attachment:
SOLR_6807__fix__stateVer__check_to_not_depend_on_handleSelect_setting.patch
Ugh; thanks for checking [~steve_rowe]! I guess I overlooked this failure;
thinking it had gone away but I was wrong.
This appears to be a real bug. Apparently the {{_stateVer_}} param checking
was occurring in the block of code that processes handleSelect dispatch
({{/select?qt=...}}) which seems quite wrong to me. In the attached patch I
moved it out to the caller (and clarified the method name / docs internally)
and am running all tests now. [~noble.paul] I suspect you added this checking
in (SOLR-7130?); could you take a look at this patch? As I get a full test run
I'll commit it to at least fix the build.
> Make handleSelect=false by default and deprecate StandardRequestHandler
> -----------------------------------------------------------------------
>
> Key: SOLR-6807
> URL: https://issues.apache.org/jira/browse/SOLR-6807
> Project: Solr
> Issue Type: Task
> Affects Versions: 4.10.2
> Reporter: Alexandre Rafalovitch
> Assignee: David Smiley
> Priority: Minor
> Labels: solrconfig.xml
> Fix For: master (7.0)
>
> Attachments:
> SOLR_6807__fix__stateVer__check_to_not_depend_on_handleSelect_setting.patch,
> SOLR_6807_handleSelect_false.patch, SOLR_6807_handleSelect_false.patch,
> SOLR_6807_handleSelect_false.patch, SOLR_6807_test_files.patch
>
>
> In the solrconfig.xml, we have a long explanation on the legacy
> *<requestDispatcher handleSelect="false" >* section. Since we are cleaning up
> legacy stuff for version 5, is it safe now to flip handleSelect's default to
> be *false* and therefore remove both the attribute and the whole section
> explaining it?
> Then, a section in Reference Guide or even a blog post can explain what to do
> for the old clients that still need it. But it does not seem to be needed
> anymore for the new users. And possibly cause confusing now that we have
> implicit, explicit and overlay handlers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
