[
https://issues.apache.org/jira/browse/SOLR-10962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068795#comment-16068795
]
Hoss Man commented on SOLR-10962:
---------------------------------
i'm not really familiar with this code -- so i'm making an assumption based on
trust in christine that the entire premise of this issue makes sense. Based on
that assumption and a quick skim of the patch, i think the overall approach is
sound, but frankly I think the {{LOG.warn("Beginning with Solr 7.0...}} line is
too weak, and should be something like...
{code}
// remove this error check & backcompat logic when Version.LUCENE_7_0_0 is
removed
Config.assertWarnOrFail(
"Begining with Solr 7.0, master."+RESERVE + " is deprecated and should now be
configured directly on the ReplicationHandler",
(null == reserve),
core.solrConfig.luceneMatchVersion.onOrAfter(Version.LUCENE_7_0_0));
{code}
that way:
* anyone starting with a clean (example) config will get an error if they try
to use the old sytnax
* anyone upgrading with an old config will just get a warning - until/unless
they change the {{<luceneMatchVersion/>}} in their solrconfig.xml t which point
they must also change this
* once LUCENE_7_0_0 is removed from the code base, this error handling will
stop compiling and we'll get a built in reminder that this special error
checking (and the back compat code wrapped around it) can be removed.
(this pattern is is entire point of assertWarnOrFail)
> replicationHandler's reserveCommitDuration configurable in SolrCloud mode
> -------------------------------------------------------------------------
>
> Key: SOLR-10962
> URL: https://issues.apache.org/jira/browse/SOLR-10962
> Project: Solr
> Issue Type: New Feature
> Components: replication (java)
> Reporter: Ramsey Haddad
> Priority: Minor
> Attachments: SOLR-10962.patch, SOLR-10962.patch, SOLR-10962.patch
>
>
> With SolrCloud mode, when doing replication via IndexFetcher, we occasionally
> see the Fetch fail and then get restarted from scratch in cases where an
> Index file is deleted after fetch manifest is computed and before the fetch
> actually transfers the file. The risk of this happening can be reduced with a
> higher value of reserveCommitDuration. However, the current configuration
> only allows this value to be adjusted for "master" mode. This change allows
> the value to also be changed when using "SolrCloud" mode.
> https://lucene.apache.org/solr/guide/6_6/index-replication.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
