Github user diegoceccarelli commented on the issue:
https://github.com/apache/lucene-solr/pull/202
@m-khl I updated the patch, highlights:
1. I removed `prepare` and relied on the old `setContext()`;
2. now a DocTransformer implements Closeable and provides the method
`close()`
3. If a transformer fails it doesn't affect the other trasformers (+
Test)
TODO:
I didn't find a way to check that DocTrasformer::close is always called in
the tests, any idea?
The `close()` is called from `DocsStreamer` so RealTimeGetRequest component
should not be affected by this change, do you think it should?
minor: I think we should rename the Jira item in something like `Make
DocTransformer Closeable` or something like that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
