[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmet Arslan updated LUCENE-7585:
---------------------------------
Attachment: LUCENE-7585.patch
Sorry for the huge delay. This patch addresses the issues raised by David.
* consumeAllTokens is used by LimitTokenOffset and LimitTokenPosition too.
* applies Yonik's concept
* improved javadoc. Some arguments are difficult since they have different
meanings in different components.
* covers a few more overlooked analysis factories
* spotted a copy-paste mistake
Any feedback is appreciated.
> Interface for common parameters used across analysis factories
> --------------------------------------------------------------
>
> Key: LUCENE-7585
> URL: https://issues.apache.org/jira/browse/LUCENE-7585
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 6.3
> Reporter: Ahmet Arslan
> Assignee: David Smiley
> Priority: Minor
> Fix For: 7.0
>
> Attachments: LUCENE-7585.patch, LUCENE-7585.patch, LUCENE-7585.patch,
> LUCENE-7585.patch, LUCENE-7585.patch, LUCENE-7585.patch, LUCENE-7585.patch
>
>
> Certain parameters (String constants) are same/common for multiple analysis
> factories. Some examples are {{ignoreCase}}, {{dictionary}}, and
> {{preserveOriginal}}. These string constants are handled inconsistently in
> different factories. This is an effort to define most common constants in
> ({{CommonAnalysisFactoryParams}}) interface and reuse them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
