[
https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072975#comment-16072975
]
Jason Gerlowski commented on SOLR-10456:
----------------------------------------
> In the following code, guess we should rename this to just LBClientTimeouts?
> or are you thinking that this could be more?
I named it generically so that it could possibly be expanded to fit other
properties such as the RequestWriter and ResponseParser in the future.
But we could always name the method specifically and generalize it if we need
to. Either way would be fine with me.
> There's also a ton of duplication of the timeout code, and it would be good
> to have that as an interface that the builder
As I was almost finished with the patch, I though of having a
"SolrClientBuilder" abstract class, which has protected fields and the
{{withFoo}} methods that are common across many of the implementations to cut
down on a lot of the duplication. Is that close to what you were proposing, or
did you have a better idea? Either way, as you mentioned, that might be better
left for a different JIRA. Though if you're prefer I can address it here too.
> timeout-related setters should be deprecated in favor of SolrClientBuilder
> methods
> ----------------------------------------------------------------------------------
>
> Key: SOLR-10456
> URL: https://issues.apache.org/jira/browse/SOLR-10456
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Assignee: Anshum Gupta
> Priority: Minor
> Fix For: 7.0
>
> Attachments: SOLR-10456.patch, SOLR-10456.patch, SOLR-10456.patch,
> SOLR-10456.patch
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each
> {{SolrClient}} can be deprecated, and their functionality moved over to the
> Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice
> to have all the knobs, and levers used to tweak {{SolrClient}}s available in
> a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are
> mutable. Using some {{SolrClient}} setters can result in erratic and "trappy"
> behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the
> {{setConnectionTimeout}} and {{setSoTimeout}} setters on all {{SolrClient}}
> implementations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
