[
https://issues.apache.org/jira/browse/SOLR-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074176#comment-16074176
]
Shalin Shekhar Mangar commented on SOLR-10983:
----------------------------------------------
On second thought, creating a batch enqueue command is not so straightforward
and the callback is called once per enqueue as per the contract of
ZkWriteCallback so it is technically not a bug. So I am fine with your solution
as it exists. +1 to commit. Please make sure it is backported to the branch_7x
and branch_7_0 so that it makes it into the 7.0 release.
> Fix DOWNNODE -> queue-work explosion
> ------------------------------------
>
> Key: SOLR-10983
> URL: https://issues.apache.org/jira/browse/SOLR-10983
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: Scott Blum
> Assignee: Scott Blum
> Attachments: SOLR-10983.patch
>
>
> Every DOWNNODE command enqueues N copies of itself into queue-work, where N
> is number of collections affected by the DOWNNODE.
> This rarely matters in practice, because queue-work gets immediately dumped--
> however, if anything throws an exception (such as ZK bad version), we don't
> clear queue-work. Then the next time through the loop we run the expensive
> DOWNNODE command potentially hundreds of times.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]