[ 
https://issues.apache.org/jira/browse/SOLR-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075535#comment-16075535
 ] 

Hoss Man commented on SOLR-10123:
---------------------------------


bq. Houston is working on a new batch of tests that will specifically test the 
new analytics expression language. I'm going to wait until those are added (and 
checked) before merging this PR.

I haven't reviewed the patch in depth, but since it appears to fix some genuine 
bugs with point field handling (see changes to existing "instanceof TrieField") 
in addition to already improving the test coverage of points, i would urge you 
to commit ASAP if you think it's good enough -- a "bug fix with tests" patch 
shouldn't be blocked waiting on more tests.

bq. ...do you have any other concerns about this and/or possible ramifications 
of this change?

My chief concern was that points be tested if the new code was going to claim 
it works with points -- either that or file some "known issues" bugs 
documenting the problems and use \@SuppressPointFields to indicate them -- as 
opposed to how this issue currently exists on master: w/o any attempt at 
testing points at all.  If the tests already committed by this issue can be 
made to work with points by committing the PR, then i (personally) have no 
concerns

> Analytics Component 2.0
> -----------------------
>
>                 Key: SOLR-10123
>                 URL: https://issues.apache.org/jira/browse/SOLR-10123
>             Project: Solr
>          Issue Type: New Feature
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Houston Putman
>              Labels: features
>         Attachments: SOLR-10123.patch, SOLR-10123.patch, SOLR-10123.patch
>
>
> A completely redesigned Analytics Component, introducing the following 
> features:
> * Support for distributed collections
> * New JSON request language, and response format that fits JSON better.
> * Faceting over mapping functions in addition to fields (Value Faceting)
> * PivotFaceting with ValueFacets
> * More advanced facet sorting
> * Support for PointField types
> * Expressions over multi-valued fields
> * New types of mapping functions
> ** Logical
> ** Conditional
> ** Comparison
> * Concurrent request execution
> * Custom user functions, defined within the request
> Fully backwards compatible with the orifinal Analytics Component with the 
> following exceptions:
> * All fields used must have doc-values enabled
> * Expression results can no longer be used when defining Range and Query 
> facets
> * The reverse(string) mapping function is no longer a native function



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to